Adding Rappor metrics for disabling cross-origin autoplay with sound experiment

third_party/WebKit/Source/core/html/HTMLMediaElement.h

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 271 matching lines @@
     return m_audioSourceProvider;
   }
 
   enum InvalidURLAction { DoNothing, Complain };
   bool isSafeToLoadURL(const KURL&, InvalidURLAction);
 
   // Checks to see if current media data is CORS-same-origin as the
   // specified origin.
   bool isMediaDataCORSSameOrigin(SecurityOrigin*) const;
 
+  // Returns this media element is in a cross-origin frame.
+  bool isCrossOrigin() const;

[whywhat, 2016/11/29 21:42:04]

nit: add frame to the name? it could be cross-origin if the src url is
cross-origin too.

[Zhiqiang Zhang (Slow), 2016/11/30 17:30:52]

s/isCrossOrigin/isInCrossOriginFrame

+
   void scheduleEvent(Event*);
   void scheduleTimeupdateEvent(bool periodicEvent);
 
   // Returns the "effective media volume" value as specified in the HTML5 spec.
   double effectiveMediaVolume() const;
 
   // Predicates also used when dispatching wrapper creation (cf.
   // [SpecialWrapFor] IDL attribute usage.)
   virtual bool isHTMLAudioElement() const { return false; }
   virtual bool isHTMLVideoElement() const { return false; }
@@ skipping 209 matching lines @@
   // TODO(zqzhang): move this to anonymous namespace when AutoplayExperiment is
   // removed. See https://crbug.com/666370
   bool computeLockedPendingUserGesture(Document&) const;
 
   // Return true if and only if a user gesture is required to unlock this
   // media element for unrestricted autoplay / script control.  Don't confuse
   // this with isGestureNeededForPlayback().  The latter is usually what one
   // should use, if checking to see if an action is allowed.
   bool isLockedPendingUserGesture() const;
 
+  bool isLockedPendingUserGestureIfCrossOriginExperimentEnabled() const;

[whywhat, 2016/11/29 21:42:05]

can't this be part of the method above instead? it's meant to be a universal
method.

[Zhiqiang Zhang (Slow), 2016/11/30 17:30:52]

Please see the other reply.

+
   // If the user gesture is required, then this will remove it.  Note that
   // one should not generally call this method directly; use the one on
   // m_helper and give it a reason.
   void unlockUserGesture();
 
   // Return true if and only if a user gesture is requried for playback.  Even
   // if isLockedPendingUserGesture() return true, this might return false if
   // the requirement is currently overridden.  This does not check if a user
   // gesture is currently being processed.
   bool isGestureNeededForPlayback() const;
 
+  bool isGestureNeededForPlaybackIfCrossOriginExperimentEnabled() const;

[whywhat, 2016/11/29 21:42:05]

ditto

+
   // Return true if and only if the settings allow autoplay of media on this
   // frame.
   bool isAutoplayAllowedPerSettings() const;
 
   void setNetworkState(NetworkState);
 
   void audioTracksTimerFired(TimerBase*);
 
   // TODO(liberato): remove once autoplay gesture override experiment concludes.
   void triggerAutoplayViewportCheckForTesting();
@@ skipping 84 matching lines @@
   mutable double m_officialPlaybackPosition;
   mutable bool m_officialPlaybackPositionNeedsUpdate;
 
   double m_fragmentEndTime;
 
   typedef unsigned PendingActionFlags;
   PendingActionFlags m_pendingActionFlags;
 
   // FIXME: HTMLMediaElement has way too many state bits.
   bool m_lockedPendingUserGesture : 1;
+  bool m_lockedPendingUserGestureIfCrossOriginExperimentEnabled : 1;
   bool m_playing : 1;
   bool m_shouldDelayLoadEvent : 1;
   bool m_haveFiredLoadedData : 1;
   bool m_autoplaying : 1;
   bool m_muted : 1;
   bool m_paused : 1;
   bool m_seeking : 1;
 
   // data has not been loaded since sending a "stalled" event
   bool m_sentStalledEvent : 1;
@@ skipping 98 matching lines @@
 
 inline bool isHTMLMediaElement(const HTMLElement& element) {
   return isHTMLAudioElement(element) || isHTMLVideoElement(element);
 }
 
 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLMediaElement);
 
 }  // namespace blink
 
 #endif  // HTMLMediaElement_h