VR: Disable Overscroll Glow in VrShell

chrome/browser/android/vr_shell/vr_shell.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/vr_shell.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "chrome/browser/android/vr_shell/ui_elements.h"
 #include "chrome/browser/android/vr_shell/ui_interface.h"
 #include "chrome/browser/android/vr_shell/ui_scene.h"
 #include "chrome/browser/android/vr_shell/vr_compositor.h"
 #include "chrome/browser/android/vr_shell/vr_controller.h"
 #include "chrome/browser/android/vr_shell/vr_gl_util.h"
 #include "chrome/browser/android/vr_shell/vr_input_manager.h"
 #include "chrome/browser/android/vr_shell/vr_shell_delegate.h"
 #include "chrome/browser/android/vr_shell/vr_shell_renderer.h"
 #include "chrome/browser/android/vr_shell/vr_usage_monitor.h"
 #include "chrome/browser/android/vr_shell/vr_web_contents_observer.h"
 #include "chrome/browser/browser_process.h"
 #include "components/rappor/rappor_utils.h"
+#include "content/public/browser/browser_thread.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/referrer.h"
 #include "device/vr/android/gvr/gvr_device_provider.h"
 #include "jni/VrShellImpl_jni.h"
 #include "ui/android/view_android.h"
 #include "ui/android/window_android.h"
@@ skipping 197 matching lines @@
 
 void VrShell::GvrInit(JNIEnv* env,
                       const JavaParamRef<jobject>& obj,
                       jlong native_gvr_api) {
   base::AutoLock lock(gvr_init_lock_);
 
   // set the initial webvr state
   metrics_helper_->SetWebVREnabled(webvr_mode_);
   metrics_helper_->SetVRActive(true);
 
+  SetShowingOverscrollGlow(false);

[bshe, 2016/11/25 14:55:00]

I am assuming this is the place that calling SetShowingOverscrollGlow on render
thread? Is it possible to move it to ctor of VrShell. IIUC, VrShell is created
on UI thread. This way, you don't need the thread check in the function
implementation?

[asimjour1, 2016/12/01 20:17:45]

ctor of VrShell is called on UI thread, but RenderViewHost is not ready at that
time.

[bshe, 2016/12/01 20:43:41]

Is it possible to call it once RVH is ready on UI thread?
Would be nice to do everything on a single thread.

[mthiesse, 2016/12/01 22:15:39]

Yes, please add RenderViewHostChanged to vr_web_contents_observer, and call
SetShowingOverscrollGlow from there.

[asimjour1, 2016/12/05 18:57:08]

Done.

[asimjour1, 2016/12/05 18:57:08]

Done.

+
   gvr_api_ =
       gvr::GvrApi::WrapNonOwned(reinterpret_cast<gvr_context*>(native_gvr_api));
   // TODO(klausw,crbug.com/655722): should report OnGvrDelegateReady here once
   // we switch to using a WebVR render surface. We currently need to wait for
   // the compositor window's size to be known first. See also
   // ContentSurfaceChanged.
   controller_.reset(
       new VrController(reinterpret_cast<gvr_context*>(native_gvr_api)));
   content_input_manager_ = new VrInputManager(main_contents_);
   ui_input_manager_ = new VrInputManager(ui_contents_);
@@ skipping 615 matching lines @@
 void VrShell::OnTriggerEvent(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   // Set a flag to handle this on the render thread at the next frame.
   touch_pending_ = true;
 }
 
 void VrShell::OnPause(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   if (gvr_api_ == nullptr)
     return;
   controller_->OnPause();
   gvr_api_->PauseTracking();
+  SetShowingOverscrollGlow(true);
 
   // exit vr session
   metrics_helper_->SetVRActive(false);
 }
 
 void VrShell::OnResume(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   if (gvr_api_ == nullptr)
     return;
 
   gvr_api_->RefreshViewerProfile();
   gvr_api_->ResumeTracking();
   controller_->OnResume();
+  SetShowingOverscrollGlow(false);
 
   // exit vr session
   metrics_helper_->SetVRActive(true);
 }
 
+void VrShell::SetShowingOverscrollGlow(bool showing_glow) {
+  if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)) {
+    content::BrowserThread::PostTask(
+        content::BrowserThread::UI, FROM_HERE,
+        base::Bind(&VrShell::SetShowingOverscrollGlow,
+                   weak_ptr_factory_.GetWeakPtr(), showing_glow));
+  } else {
+    main_contents_->GetRenderWidgetHostView()->SetShowingOverscrollGlow(
+        showing_glow);
+  }
+}
+
 base::WeakPtr<VrShell> VrShell::GetWeakPtr(
     const content::WebContents* web_contents) {
   // Ensure that the WebContents requesting the VrShell instance is the one
   // we created.
   if (g_instance != nullptr && g_instance->ui_contents_ == web_contents)
     return g_instance->weak_ptr_factory_.GetWeakPtr();
   return base::WeakPtr<VrShell>(nullptr);
 }
 
 void VrShell::OnDomContentsLoaded() {
@@ skipping 149 matching lines @@
            const JavaParamRef<jobject>& ui_web_contents,
            jlong ui_window_android) {
   return reinterpret_cast<intptr_t>(new VrShell(
       env, obj, content::WebContents::FromJavaWebContents(content_web_contents),
       reinterpret_cast<ui::WindowAndroid*>(content_window_android),
       content::WebContents::FromJavaWebContents(ui_web_contents),
       reinterpret_cast<ui::WindowAndroid*>(ui_window_android)));
 }
 
 }  // namespace vr_shell