ios/chrome/browser/find_in_page/find_in_page_model.h - Issue 2524383002: [ObjC ARC] Converts ios/chrome/browser/find_in_page:find_in_page to ARC.Automatically generated A…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/find_in_page/find_in_page_model.h

Issue 2524383002: [ObjC ARC] Converts ios/chrome/browser/find_in_page:find_in_page to ARC.Automatically generated A… (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/find_in_page/find_in_page_model.h

diff --git a/ios/chrome/browser/find_in_page/find_in_page_model.h b/ios/chrome/browser/find_in_page/find_in_page_model.h

index dedb5f42273ac7488f5e8d533a9c83be8e1ba058..96950029ccf216afb85d57ea1025731cc631e925 100644

--- a/ios/chrome/browser/find_in_page/find_in_page_model.h

+++ b/ios/chrome/browser/find_in_page/find_in_page_model.h

@@ -15,7 +15,7 @@

@property(nonatomic, assign) BOOL enabled;

// The current search string.

-@property(nonatomic, readonly) NSString* text;

+@property(weak, nonatomic, readonly) NSString* text;

noyau (Ping after 24h) 2016/11/25 10:27:46 Weak? The implementation is doing copy... For a re

stkhapugin 2016/11/25 11:23:03 Done.

// The number of matches for |text|.

@property(nonatomic, readonly) NSUInteger matches;