Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1558)

Unified Diff: components/metrics/metrics_service.cc

Issue 2524363003: Support experiment configurations with/without stability metrics. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service.cc
diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc
index 5c9448987ab9b42348f2ed6a8b0743936542dacb..ed15edfb11bb547c5fc780bef30a0d642958ea24 100644
--- a/components/metrics/metrics_service.cc
+++ b/components/metrics/metrics_service.cc
@@ -914,12 +914,11 @@ void MetricsService::SendNextLog() {
bool MetricsService::ProvidersHaveInitialStabilityMetrics() {
// Check whether any metrics provider has initial stability metrics.
- for (MetricsProvider* provider : metrics_providers_) {
- if (provider->HasInitialStabilityMetrics())
- return true;
- }
+ bool has_stability_metrics = false;
+ for (MetricsProvider* provider : metrics_providers_)
+ has_stability_metrics |= provider->HasInitialStabilityMetrics();
Alexei Svitkine (slow) 2016/11/24 21:27:58 Please add a comment above why this doesn't do an
bcwhite 2016/11/25 18:51:58 Done.
- return false;
+ return has_stability_metrics;
}
bool MetricsService::PrepareInitialStabilityLog(
« components/metrics/file_metrics_provider.cc ('K') | « components/metrics/file_metrics_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698