Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2524363002: [regexp] Add file-level typedefs to builtins-regexp.cc (Closed)

Created:
4 years ago by jgruber
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Add file-level typedefs to builtins-regexp.cc This removes lots of boilerplate typedefs, with the caveat of renaming CSA::Label and Variable to CLabel and CVariable within builtins-regexp. BUG=v8:5339 Committed: https://crrev.com/485067c66b93d41047f9379005da85d3ee0baca1 Cr-Commit-Position: refs/heads/master@{#41281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -186 lines) Patch
M src/builtins/builtins-regexp.cc View 56 chunks +110 lines, -186 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
jgruber
Small refactoring in builtins-regexp.cc.
4 years ago (2016-11-25 06:26:28 UTC) #6
Yang
On 2016/11/25 06:26:28, jgruber wrote: > Small refactoring in builtins-regexp.cc. lgtm.
4 years ago (2016-11-25 06:39:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524363002/1
4 years ago (2016-11-25 08:29:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 08:31:05 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-25 08:31:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/485067c66b93d41047f9379005da85d3ee0baca1
Cr-Commit-Position: refs/heads/master@{#41281}

Powered by Google App Engine
This is Rietveld 408576698