Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2524333002: [ast] Don't assume declaration scopes are never removed. (Closed)

Created:
4 years ago by neis
Modified:
4 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Don't assume declaration scopes are never removed. Because they sometimes are. R=rossberg@chromium.org BUG=v8:5648 Committed: https://crrev.com/f447aeac4d31666342174ff7ff04a92dfee67dfd Cr-Commit-Position: refs/heads/master@{#41262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ast/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
neis
4 years ago (2016-11-24 12:35:01 UTC) #1
rossberg
lgtm
4 years ago (2016-11-24 12:55:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524333002/1
4 years ago (2016-11-24 12:55:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 13:22:34 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-24 13:23:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f447aeac4d31666342174ff7ff04a92dfee67dfd
Cr-Commit-Position: refs/heads/master@{#41262}

Powered by Google App Engine
This is Rietveld 408576698