third_party/WebKit/LayoutTests/accessibility/css-first-letter-children.html - Issue 2524313002: Fix AXLayoutObject not to add duplicated children for CSS first-letter

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/accessibility/css-first-letter-children.html

Issue 2524313002: Fix AXLayoutObject not to add duplicated children for CSS first-letter (Closed)

Patch Set: eae review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <style>

	5 p::first-letter {

	6 font-size: 200%;

	7 }

	8 </style>

	9 <p id="text">Test text</p>

	10 <script>

	11 test(function () {

	12 if (!window.accessibilityController) {

	13 assert_unreached("This test requires accessibilityController.");

	14 return;

	15 }

	16

	17 function getAccessibilityChildren(element) {

	18 let children = [];

	19 let childrenCount = element.childrenCount;

	20 for (let i = 0; i < childrenCount; i++) {

	21 let child = element.childAtIndex(i);

	22 children.push(child);

	23 child.children = getAccessibilityChildren(child);

	24 }

	25 return children;

	26 }

	27

	28 let element = accessibilityController.accessibleElementById("text");

	29 let children = getAccessibilityChildren(element);
	dmazzoni 2016/11/28 07:50:09 This test is reasonable but it's a bit more rounda This test is reasonable but it's a bit more roundabout than what I would have done. A simpler test would be to use an element that gets its own accessible name, like a heading element, as in the example in the linked bug. If you use <h1 id="text">Test text</h1>, then element.name should equal "Test text" and if the bug report is correct that would have failed before. This doesn't work for a paragraph because paragraph elements don't have their own accessible name, so instead you have to walk the children. Go ahead and leave this test, but I'd include a test above this one in the same file with the simpler assertion.
	30 assert_equals(children.length, 1);

	31 let name = children.map(e => e.name).join('');

	32 assert_equals(name, "Test text");

	33 });

	34 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/accessibility/first-letter-text-transform-causes-crash-expected.txt » ('j') | no next file with comments »