Fix AXLayoutObject not to add duplicated children for CSS first-letter

third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

 /*
 * Copyright (C) 2008 Apple Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 44 matching lines @@
 #include "core/html/LabelsNodeList.h"
 #include "core/html/shadow/ShadowElementNames.h"
 #include "core/layout/HitTestResult.h"
 #include "core/layout/LayoutFileUploadControl.h"
 #include "core/layout/LayoutHTMLCanvas.h"
 #include "core/layout/LayoutImage.h"
 #include "core/layout/LayoutInline.h"
 #include "core/layout/LayoutListMarker.h"
 #include "core/layout/LayoutMenuList.h"
 #include "core/layout/LayoutTextControl.h"
+#include "core/layout/LayoutTextFragment.h"
 #include "core/layout/LayoutView.h"
 #include "core/layout/api/LayoutAPIShim.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/layout/api/LineLayoutAPIShim.h"
 #include "core/loader/ProgressTracker.h"
 #include "core/page/Page.h"
 #include "core/paint/PaintLayer.h"
 #include "core/style/ComputedStyleConstants.h"
 #include "core/svg/SVGDocumentExtensions.h"
 #include "core/svg/SVGSVGElement.h"
@@ skipping 39 matching lines @@
   if (!layoutObject->isLayoutInline())
     return false;
 
   return toLayoutInline(layoutObject)->continuation();
 }
 
 static inline LayoutObject* firstChildConsideringContinuation(
     LayoutObject* layoutObject) {
   LayoutObject* firstChild = layoutObject->slowFirstChild();
 
+  if (firstChild && firstChild->isText() &&
+      toLayoutText(firstChild)->isTextFragment() &&
+      toLayoutTextFragment(firstChild)->firstLetterPseudoElement())
+    firstChild = nullptr;

[eae, 2016/11/24 21:50:13]

Shouldn't this be return nullptr to ensure that it's not overriden by the next
statement?

[kojii, 2016/11/25 06:38:35]

Done, thank you.

+
   if (!firstChild && isInlineWithContinuation(layoutObject))
     firstChild = firstChildInContinuation(toLayoutInline(*layoutObject));
 
   return firstChild;
 }
 
 static inline LayoutInline* startOfContinuations(LayoutObject* r) {
   if (r->isInlineElementContinuation()) {
     return toLayoutInline(r->node()->layoutObject());
   }
@@ skipping 2268 matching lines @@
 
 bool AXLayoutObject::elementAttributeValue(
     const QualifiedName& attributeName) const {
   if (!m_layoutObject)
     return false;
 
   return equalIgnoringCase(getAttribute(attributeName), "true");
 }
 
 }  // namespace blink