Add a mojo struct corresponding and typemapped to base::File.

Add a mojo struct corresponding and typemapped to base::File.

BUG=668384
Committed: https://crrev.com/e4f1e3532706ce0b82c8a54fadb9f35eb786bd2f
Cr-Commit-Position: refs/heads/master@{#434772}

[Sam McNally, 2016-11-24 07:26:44]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 07:27:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 07:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 07:30:46]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Sam McNally, 2016-11-24 08:59:59]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 09:00:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-24 09:07:23]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-11-24 09:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 09:32:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Sam McNally, 2016-11-24 09:35:21]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 09:35:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-24 09:36:39]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-11-24 10:15:03]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 10:15:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-24 11:46:56]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-11-24 11:50:44]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 11:51:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-24 11:52:40]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-11-24 13:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:52:50]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Sam McNally, 2016-11-24 22:39:26]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 22:39:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-24 22:49:10]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 22:49:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-24 22:50:58]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-11-24 23:25:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 23:25:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-11-25 00:38:20]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 00:38:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-25 00:42:08]

sammc@chromium.org changed reviewers:
+ dcheng@chromium.org, rockot@chromium.org

[Sam McNally, 2016-11-25 00:42:09]

+rockot for //mojo

+dcheng for //base, mojom and struct traits

[commit-bot: I haz the power, 2016-11-25 00:58:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 00:58:53]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-11-28 17:25:07]

base/mojom/struct traits lgtm

https://codereview.chromium.org/2524293002/diff/100001/mojo/common/common_cus...
File mojo/common/common_custom_types_struct_traits.h (right):

https://codereview.chromium.org/2524293002/diff/100001/mojo/common/common_cus...
mojo/common/common_custom_types_struct_traits.h:78: static mojo::ScopedHandle
fd(base::File& file);
Nit: const

[Ken Rockot(use gerrit already), 2016-11-28 20:12:47]

LGTM

[Sam McNally, 2016-11-28 21:21:48]

https://codereview.chromium.org/2524293002/diff/100001/mojo/common/common_cus...
File mojo/common/common_custom_types_struct_traits.h (right):

https://codereview.chromium.org/2524293002/diff/100001/mojo/common/common_cus...
mojo/common/common_custom_types_struct_traits.h:78: static mojo::ScopedHandle
fd(base::File& file);
On 2016/11/28 17:25:07, dcheng wrote:
> Nit: const

It has to be non-const to TakePlatformFile().

[Sam McNally, 2016-11-28 21:22:10]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:23:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 23:28:32]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480368130467590,
"parent_rev": "76a77ccd44e69991c7cfbf4cab1198016a092061", "commit_rev":
"c0884b43261b4ea8095388993ac0c66fc36350cc"}

[commit-bot: I haz the power, 2016-11-28 23:28:58]

Committed patchset #1 (id:100001)

[commit-bot: I haz the power, 2016-11-28 23:32:54]

Description was changed from

==========
Add a mojo struct corresponding and typemapped to base::File.

BUG=668384
==========

to

==========
Add a mojo struct corresponding and typemapped to base::File.

BUG=668384

Committed: https://crrev.com/e4f1e3532706ce0b82c8a54fadb9f35eb786bd2f
Cr-Commit-Position: refs/heads/master@{#434772}
==========

[commit-bot: I haz the power, 2016-11-28 23:32:55]

Patchset 1 (id:??) landed as
https://crrev.com/e4f1e3532706ce0b82c8a54fadb9f35eb786bd2f
Cr-Commit-Position: refs/heads/master@{#434772}