Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2524263003: Treat all functions in a 'comma sequence' the same for (pre-)parsing. (Closed)

Created:
4 years ago by vogelheim
Modified:
4 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Treat all functions in a 'comma sequence' the same for (pre-)parsing. R=verwaest@chromium.org BUG=v8:5643 Committed: https://crrev.com/9d0f5ab74512f8c28e93df8f2514505e1eff3436 Cr-Commit-Position: refs/heads/master@{#41267}

Patch Set 1 #

Patch Set 2 : Maybe things should compile, too. #

Patch Set 3 : Minor fix. #

Patch Set 4 : Minor drive-by rework of the tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -25 lines) Patch
M src/parsing/parser-base.h View 1 2 4 chunks +20 lines, -5 lines 0 comments Download
M test/cctest/parsing/test-parse-decision.cc View 1 2 3 3 chunks +58 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
vogelheim
ptal :)
4 years ago (2016-11-24 12:50:00 UTC) #9
Toon Verwaest
lgtm
4 years ago (2016-11-24 13:52:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524263003/60001
4 years ago (2016-11-24 14:19:00 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-24 14:45:05 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-24 14:45:26 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9d0f5ab74512f8c28e93df8f2514505e1eff3436
Cr-Commit-Position: refs/heads/master@{#41267}

Powered by Google App Engine
This is Rietveld 408576698