Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 252423008: Reland Properly set alpha type in webp decode. (Closed)

Created:
6 years, 8 months ago by scroggo
Modified:
6 years, 8 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Reland "Properly set alpha type in webp decode." Also use the newer setConfig function. Add a test to confirm that we set the alpha type properly. Add some images with alpha for testing. (These images are also beneficial for the compare_unpremul test, which was previously not meaningful on 100% opaque images.) All of the added images are in the public domain. They were taken from https://developers.google.com/speed/webp/gallery2: yellow_rose: "Free Stock Photo in High Resolution - Yellow Rose 3 - Flowers" Image Author: Jon Sullivan This file is in the public domain. http://www.public-domain-photos.com/free-stock-photos-4/flowers/yellow-rose-3.jpg baby_tux: "baby tux for my user page" Image Author: Fizyplankton This file is in the public domain. http://www.minecraftwiki.net/images/8/85/Fizyplankton.png NOTRY=true TBR=halcanary@google.com BUG=skia:2388 Committed: http://code.google.com/p/skia/source/detail?r=14360

Patch Set 1 : Duplicate of https://codereview.chromium.org/223893002/ #

Patch Set 2 : Only run the test on Android and Unix #

Patch Set 3 : No change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -2 lines) Patch
A resources/baby_tux.png View Binary file 0 comments Download
A resources/baby_tux.webp View Binary file 0 comments Download
A resources/half-transparent-white-pixel.png View Binary file 0 comments Download
A resources/half-transparent-white-pixel.webp View Binary file 0 comments Download
A resources/yellow_rose.png View Binary file 0 comments Download
A resources/yellow_rose.webp View Binary file 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 1 chunk +14 lines, -2 lines 0 comments Download
M tests/ImageDecodingTest.cpp View 1 1 chunk +156 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-24 18:47:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/252423008/20001
6 years, 8 months ago (2014-04-24 18:48:31 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 18:48:34 UTC) #3
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
6 years, 8 months ago (2014-04-24 18:48:35 UTC) #4
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-24 18:50:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/252423008/20001
6 years, 8 months ago (2014-04-24 18:50:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 18:50:55 UTC) #7
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
6 years, 8 months ago (2014-04-24 18:50:55 UTC) #8
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-24 18:54:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/252423008/40001
6 years, 8 months ago (2014-04-24 18:54:56 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 18:55:19 UTC) #11
Message was sent while issue was closed.
Change committed as 14360

Powered by Google App Engine
This is Rietveld 408576698