Correct EmbeddedTestServer usage in Android tests.

Correct EmbeddedTestServer usage in Android tests.

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

The request handler for "/slow?" gets added to the server when
AddDefaultHandlers() is called[1], which already happens in
createAndStartServer(), so the additional call here isn't necessary.

[1] https://cs.chromium.org/chromium/src/net/test/embedded_test_server/embedded_test_server.cc?sq=package:chromium&dr=C&rcl=1480321223&l=295

BUG=546060
Committed: https://crrev.com/defbb64ff39e797cee7c26715d37a0ce7f875816
Cr-Commit-Position: refs/heads/master@{#434773}

[martijnc, 2016-11-23 20:25:22]

martijn@martijnc.be changed reviewers:
+ dfalcantara@chromium.org

[martijnc, 2016-11-23 20:58:37]

Patchset #1 (id:1) has been deleted

[martijnc, 2016-11-23 22:00:48]

martijn@martijnc.be changed reviewers:
- dfalcantara@chromium.org

[martijnc, 2016-11-24 19:23:09]

Patchset #1 (id:20001) has been deleted

[martijnc, 2016-11-24 19:35:23]

Patchset #1 (id:40001) has been deleted

[martijnc, 2016-11-28 15:43:17]

Description was changed from

==========
Correct EmbeddedTestServer usage in Android tests.

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

BUG=546060
==========

to

==========
Correct EmbeddedTestServer usage in Android tests.

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

The request handler for "/slow?" gets added to the server when
AddDefaultHandlers() is called[1], which already happens in
createAndStartServer(), so the additional call here isn't necessary.

[1]
https://cs.chromium.org/chromium/src/net/test/embedded_test_server/embedded_t...

BUG=546060
==========

[martijnc, 2016-11-28 15:43:17]

martijn@martijnc.be changed reviewers:
+ dfalcantara@chromium.org

[martijnc, 2016-11-28 15:46:07]

Hi, can you review this patch?

Thanks!

[gone, 2016-11-28 18:59:28]

dfalcantara@chromium.org changed reviewers:
+ jbudorick@chromium.org

[gone, 2016-11-28 18:59:28]

John: do you know who knows how the EmbeddedTestServer works nowadays?

[jbudorick, 2016-11-28 21:34:40]

lgtm

On 2016/11/28 18:59:28, dfalcantara (check my queue) wrote:
> John: do you know who knows how the EmbeddedTestServer works nowadays?

I do :)

The description is correct. This was previously createAndStartFileServer, which
at the time didn't add any handlers.

[gone, 2016-11-28 21:37:49]

Thanks ;)

lgtm

[martijnc, 2016-11-28 21:45:04]

The CQ bit was checked by martijn@martijnc.be

[commit-bot: I haz the power, 2016-11-28 21:46:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 23:29:34]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480369504152860,
"parent_rev": "c0884b43261b4ea8095388993ac0c66fc36350cc", "commit_rev":
"0302728176c77a0d5f8343f55f86c81b8b9ccf3b"}

[commit-bot: I haz the power, 2016-11-28 23:30:04]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-11-28 23:32:56]

Description was changed from

==========
Correct EmbeddedTestServer usage in Android tests.

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

The request handler for "/slow?" gets added to the server when
AddDefaultHandlers() is called[1], which already happens in
createAndStartServer(), so the additional call here isn't necessary.

[1]
https://cs.chromium.org/chromium/src/net/test/embedded_test_server/embedded_t...

BUG=546060
==========

to

==========
Correct EmbeddedTestServer usage in Android tests.

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

The request handler for "/slow?" gets added to the server when
AddDefaultHandlers() is called[1], which already happens in
createAndStartServer(), so the additional call here isn't necessary.

[1]
https://cs.chromium.org/chromium/src/net/test/embedded_test_server/embedded_t...

BUG=546060

Committed: https://crrev.com/defbb64ff39e797cee7c26715d37a0ce7f875816
Cr-Commit-Position: refs/heads/master@{#434773}
==========

[commit-bot: I haz the power, 2016-11-28 23:32:57]

Patchset 2 (id:??) landed as
https://crrev.com/defbb64ff39e797cee7c26715d37a0ce7f875816
Cr-Commit-Position: refs/heads/master@{#434773}