Chromium Code Reviews| Index: net/log/trace_net_log_observer_unittest.cc |
| diff --git a/net/log/trace_net_log_observer_unittest.cc b/net/log/trace_net_log_observer_unittest.cc |
| index 60c54ee0f9fbd74941f687756c3adb5a81ad864e..e5a62c65e363f9e95c7e7e3a91a2b5250f8d2583 100644 |
| --- a/net/log/trace_net_log_observer_unittest.cc |
| +++ b/net/log/trace_net_log_observer_unittest.cc |
| @@ -319,6 +319,31 @@ TEST_F(TraceNetLogObserverTest, CreateObserverAfterTracingStarts) { |
| TestNetLogEntry::List entries; |
| net_log()->GetEntries(&entries); |
| EXPECT_EQ(3u, entries.size()); |
| + EXPECT_EQ(1u, trace_events()->GetSize()); |
| +} |
| + |
| +TEST_F(TraceNetLogObserverTest, |
| + CreateObserverAfterTracingStartsDisabledCategory) { |
| + set_trace_net_log_observer(NULL); |
|
xunjieli
2016/11/30 18:12:32
nit: use nullptr instead of NULL in new code.
Benoit L
2016/12/01 10:41:32
Done.
|
| + |
| + std::string disabled_netlog_category = |
| + std::string("-") + kNetLogTracingCategory; |
| + TraceLog::GetInstance()->SetEnabled( |
| + base::trace_event::TraceConfig(disabled_netlog_category, ""), |
| + TraceLog::RECORDING_MODE); |
| + |
| + set_trace_net_log_observer(new TraceNetLogObserver()); |
| + trace_net_log_observer()->WatchForTraceStart(net_log()); |
| + net_log()->AddGlobalEntry(NetLogEventType::CANCELLED); |
| + trace_net_log_observer()->StopWatchForTraceStart(); |
| + net_log()->AddGlobalEntry(NetLogEventType::REQUEST_ALIVE); |
| + net_log()->AddGlobalEntry(NetLogEventType::URL_REQUEST_START_JOB); |
| + |
| + EndTraceAndFlush(); |
| + |
| + TestNetLogEntry::List entries; |
| + net_log()->GetEntries(&entries); |
| + EXPECT_EQ(3u, entries.size()); |
| EXPECT_EQ(0u, trace_events()->GetSize()); |
| } |