Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2524033004: Report more apk size metrics in resource_sizes.py (Closed)

Created:
4 years ago by agrieve
Modified:
4 years ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report more apk size metrics in resource_sizes.py Specifically, this adds: *RESULT ChromePublic.apk_Specifics: main dex size= 5914088 bytes *RESULT ChromePublic.apk_Specifics: secondary dex size= 5712 bytes *RESULT ChromePublic.apk_Specifics: main lib size= 46557792 bytes *RESULT ChromePublic.apk_Specifics: other lib size= 83540 bytes *RESULT ChromePublic.apk_Specifics: normalized apk size= 70865792 bytes *RESULT ChromePublic.apk_Specifics: file count= 2554 zip entries This also adds a handy-for-local-testing flag: --no-output-dir, which disables all metrics that rely on having an up-to-date build output (allows script to be run on any .apk). Finally, it includes .webp files along with .png files (wished this had just been called "drawables" or something, but don't want to change the name now. I've ensured that running the script before & after this change produces the same existing measurements. BUG=668238 Committed: https://crrev.com/07a7037737a96effe5a08f56458246c45a7c1283 Cr-Commit-Position: refs/heads/master@{#434263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -64 lines) Patch
M build/android/resource_sizes.py View 6 chunks +144 lines, -64 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
agrieve
On 2016/11/23 19:43:09, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:rnephew@chromium.org 💨
4 years ago (2016-11-23 19:43:33 UTC) #3
rnephew (Reviews Here)
lgtm
4 years ago (2016-11-23 19:57:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524033004/1
4 years ago (2016-11-23 20:12:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 22:05:01 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-23 22:07:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07a7037737a96effe5a08f56458246c45a7c1283
Cr-Commit-Position: refs/heads/master@{#434263}

Powered by Google App Engine
This is Rietveld 408576698