Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2524023003: Revert of Disable flaky TransportSecurityStateTest.BuiltinCertPins on Android. (Closed)

Created:
4 years ago by eroman
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky TransportSecurityStateTest.BuiltinCertPins on Android. (patchset #1 id:1 of https://codereview.chromium.org/2527723002/ ) Reason for revert: This test should no longer be flaky on Android, as we instead fail at the test-suite level when the device failed to set its clock properly. Original issue's description: > Disable flaky TransportSecurityStateTest.BuiltinCertPins on Android. > > BUG=668008 > TBR=rdsmith@chromium.org, rockot@chromium.org > > Committed: https://crrev.com/d0d5a2921f045da504fb1a8d4cfbcf89d8535ca5 > Cr-Commit-Position: refs/heads/master@{#434245} TBR=rdsmith@chromium.org,rockot@chromium.org,lukasza@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668008 Committed: https://crrev.com/1a19ef587d94c13186eafeb7997336678b320091 Cr-Commit-Position: refs/heads/master@{#434269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M net/http/transport_security_state_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
eroman
Created Revert of Disable flaky TransportSecurityStateTest.BuiltinCertPins on Android.
4 years ago (2016-11-23 22:44:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524023003/1
4 years ago (2016-11-23 22:45:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 22:46:43 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-23 22:48:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a19ef587d94c13186eafeb7997336678b320091
Cr-Commit-Position: refs/heads/master@{#434269}

Powered by Google App Engine
This is Rietveld 408576698