Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2523953002: [turbofan] Remove type feedback from AstGraphBuilder pipeline. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, rmcilroy, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove type feedback from AstGraphBuilder pipeline. The AstGraphBuilder pipeline is only used for asm.js now, so the whole type feedback mechanism is essentially dead code currently, thus we better nuke it. BUG=v8:5267, v8:5657 Committed: https://crrev.com/c17e8605691623bf2718bc9789162cb8b59de081 Cr-Commit-Position: refs/heads/master@{#41201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -276 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compilation-info.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 4 chunks +1 line, -7 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 8 chunks +7 lines, -31 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 3 chunks +1 line, -8 lines 0 comments Download
M src/compiler/pipeline.cc View 8 chunks +1 line, -30 lines 0 comments Download
D src/compiler/type-hint-analyzer.h View 1 chunk +0 lines, -57 lines 0 comments Download
D src/compiler/type-hint-analyzer.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Benedikt Meurer
Hey Yang, Here's some after-branch cleanup for the fullcodegen pipeline, removing dead code. Please take ...
4 years, 1 month ago (2016-11-23 05:52:57 UTC) #4
Yang
On 2016/11/23 05:52:57, Benedikt Meurer wrote: > Hey Yang, > > Here's some after-branch cleanup ...
4 years, 1 month ago (2016-11-23 05:56:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523953002/1
4 years, 1 month ago (2016-11-23 06:08:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-23 06:10:07 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 06:10:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c17e8605691623bf2718bc9789162cb8b59de081
Cr-Commit-Position: refs/heads/master@{#41201}

Powered by Google App Engine
This is Rietveld 408576698