Chromium Code Reviews| Index: src/arm/disasm-arm.cc |
| diff --git a/src/arm/disasm-arm.cc b/src/arm/disasm-arm.cc |
| index e408e85da387f747972e5352ba960e7a41b27ff5..e3dfed014f256db07c024bee3ce45adfca26c072 100644 |
| --- a/src/arm/disasm-arm.cc |
| +++ b/src/arm/disasm-arm.cc |
| @@ -1801,6 +1801,18 @@ static const char* const barrier_option_names[] = { |
| void Decoder::DecodeSpecialCondition(Instruction* instr) { |
| switch (instr->SpecialValue()) { |
| + case 4: |
| + if (instr->Bits(27, 23) == 4 && instr->Bits(21, 20) == 2 && |
| + instr->Bits(11, 8) == 1 && instr->Bit(4) == 1) { |
| + // vmov Qd, Qm |
|
martyn.capewell
2016/11/23 20:08:46
There's no disassembler test for this.
bbudge
2016/11/24 02:22:53
I didn't realize there were disassembler tests. Ad
|
| + int Vd = (instr->Bit(22) << 3) | (instr->VdValue() >> 1); |
| + int Vm = (instr->Bit(7) << 3) | instr->VmValue() >> 1; |
|
bbudge
2016/11/24 02:22:53
I also converted this to use the VfpXRegister func
|
| + out_buffer_pos_ += |
| + SNPrintF(out_buffer_ + out_buffer_pos_, "vmov q%d, q%d", Vd, Vm); |
| + } else { |
| + Unknown(instr); |
| + } |
| + break; |
| case 5: |
| if ((instr->Bits(18, 16) == 0) && (instr->Bits(11, 6) == 0x28) && |
| (instr->Bit(4) == 1)) { |
| @@ -1827,11 +1839,17 @@ void Decoder::DecodeSpecialCondition(Instruction* instr) { |
| "vmovl.u%d q%d, d%d", imm3*8, Vd, Vm); |
| } else if ((instr->Bits(21, 16) == 0x32) && (instr->Bits(11, 7) == 0) && |
| (instr->Bit(4) == 0)) { |
| - int Vd = instr->VFPDRegValue(kDoublePrecision); |
| - int Vm = instr->VFPMRegValue(kDoublePrecision); |
| - char rtype = (instr->Bit(6) == 0) ? 'd' : 'q'; |
| - out_buffer_pos_ += SNPrintF(out_buffer_ + out_buffer_pos_, |
| - "vswp %c%d, %c%d", rtype, Vd, rtype, Vm); |
| + if (instr->Bit(6) == 0) { |
| + int Vd = instr->VFPDRegValue(kDoublePrecision); |
| + int Vm = instr->VFPMRegValue(kDoublePrecision); |
| + out_buffer_pos_ += |
| + SNPrintF(out_buffer_ + out_buffer_pos_, "vswp d%d, d%d", Vd, Vm); |
| + } else { |
| + int Vd = instr->VFPDRegValue(kSimd128Precision); |
| + int Vm = instr->VFPMRegValue(kSimd128Precision); |
| + out_buffer_pos_ += |
| + SNPrintF(out_buffer_ + out_buffer_pos_, "vswp q%d, q%d", Vd, Vm); |
|
martyn.capewell
2016/11/23 20:08:46
There's no disassembler test for this.
bbudge
2016/11/24 02:22:53
Done.
|
| + } |
| } else { |
| Unknown(instr); |
| } |