[Android] Add GinJavaBridgeValue for Gin Java Bridge

[Android] Add GinJavaBridgeValue for Gin Java Bridge

Gin Java Bridge passes values between Java and JS using base::Value.
Since there are some kinds of data that can't be represented in JSON,
we use base::BinaryValue that holds GinJavaBridgeValue. And we don't
use base::BinaryValue for anything else (this is enforced by our
Strategy for V8ValueConverter).

BUG=355644
R=bulach@chromium.org, jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266527

[mnaganov (inactive), 2014-04-24 09:24:48]

Hi Jochen,

Since you aware of base::Value restrictions, can you please take a look at an
extension for it?

[jochen (gone - plz use gerrit), 2014-04-24 12:40:31]

lgtm

[mnaganov (inactive), 2014-04-24 12:42:11]

Thanks, Jochen!

Marcus, can you please do an OWNER review?

[bulach, 2014-04-24 12:49:26]

lgtm, thanks! one suggestion below:

https://codereview.chromium.org/252393004/diff/1/content/common/android/gin_j...
File content/common/android/gin_java_bridge_value.h (right):

https://codereview.chromium.org/252393004/diff/1/content/common/android/gin_j...
content/common/android/gin_java_bridge_value.h:31: static base::BinaryValue*
CreateUndefinedValue();
should these be returning scoped_ptr? I think factories these days use
scoped_ptr to indicate ownership is being transferred.

[mnaganov (inactive), 2014-04-24 15:24:41]

Thanks, Marcus!

https://codereview.chromium.org/252393004/diff/1/content/common/android/gin_j...
File content/common/android/gin_java_bridge_value.h (right):

https://codereview.chromium.org/252393004/diff/1/content/common/android/gin_j...
content/common/android/gin_java_bridge_value.h:31: static base::BinaryValue*
CreateUndefinedValue();
On 2014/04/24 12:49:27, bulach wrote:
> should these be returning scoped_ptr? I think factories these days use
> scoped_ptr to indicate ownership is being transferred.

A great idea! After making this change I discovered actual memory leaks in (yet
unpublished) code that uses these methods.

[mnaganov (inactive), 2014-04-24 15:27:34]

The CQ bit was checked by mnaganov@chromium.org

[commit-bot: I haz the power, 2014-04-24 15:28:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/252393004/20001

[commit-bot: I haz the power, 2014-04-24 16:02:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 16:02:29]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[mnaganov (inactive), 2014-04-24 16:07:12]

The CQ bit was checked by mnaganov@chromium.org

[commit-bot: I haz the power, 2014-04-24 16:07:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/252393004/20001

[commit-bot: I haz the power, 2014-04-24 16:15:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 16:15:26]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[mnaganov (inactive), 2014-04-24 16:39:57]

The CQ bit was checked by mnaganov@chromium.org

[commit-bot: I haz the power, 2014-04-24 16:42:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/252393004/20001

[commit-bot: I haz the power, 2014-04-24 23:48:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 23:48:09]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[mnaganov (inactive), 2014-04-25 09:29:06]

The CQ bit was checked by mnaganov@chromium.org

[mnaganov (inactive), 2014-04-25 12:18:30]

The CQ bit was unchecked by mnaganov@chromium.org

[mnaganov (inactive), 2014-04-25 12:18:37]

The CQ bit was checked by mnaganov@chromium.org

[commit-bot: I haz the power, 2014-04-25 12:51:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/252393004/40001

[commit-bot: I haz the power, 2014-04-25 23:19:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:19:41]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[mnaganov (inactive), 2014-04-28 12:34:08]

Committed patchset #4 manually as r266527 (presubmit successful).