Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2523913004:
Make sure text handle gets dismissed upon exiting action mode (Closed)
|
Created:
4 years ago by Jinsuk Kim Modified:
4 years ago Reviewers:
boliu CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake sure text handle gets dismissed upon exiting action mode
Refactoring https://crrev.com/2407303005 missed the action dismissing
text handles when exiting action mode. This CL fixes it.
BUG=666860, 668456
Committed: https://crrev.com/1a60c807f31fa8546f0acdd63380c93be95b4807
Cr-Commit-Position: refs/heads/master@{#434785}
Patch Set 1 #Patch Set 2 : fix tests #Messages
Total messages: 19 (14 generated)
The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jinsukkim@chromium.org changed reviewers: + boliu@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Make sure text handle gets dismissed upon exiting action mode Refactoring https://crrev.com/2407303005 missed the action dismissing text handles when exiting action mode. This CL fixes it. BUG=666860 ========== to ========== Make sure text handle gets dismissed upon exiting action mode Refactoring https://crrev.com/2407303005 missed the action dismissing text handles when exiting action mode. This CL fixes it. BUG=666860, 668456 ==========
lgtm
The CQ bit was checked by jinsukkim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480371597704900,
"parent_rev": "bbf24dc91b2cb11747c07d954d806f301614b3c9", "commit_rev":
"7767858f95e7f53e23cef4e9a7e07329a397bff4"}
Message was sent while issue was closed.
Description was changed from ========== Make sure text handle gets dismissed upon exiting action mode Refactoring https://crrev.com/2407303005 missed the action dismissing text handles when exiting action mode. This CL fixes it. BUG=666860, 668456 ========== to ========== Make sure text handle gets dismissed upon exiting action mode Refactoring https://crrev.com/2407303005 missed the action dismissing text handles when exiting action mode. This CL fixes it. BUG=666860, 668456 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make sure text handle gets dismissed upon exiting action mode Refactoring https://crrev.com/2407303005 missed the action dismissing text handles when exiting action mode. This CL fixes it. BUG=666860, 668456 ========== to ========== Make sure text handle gets dismissed upon exiting action mode Refactoring https://crrev.com/2407303005 missed the action dismissing text handles when exiting action mode. This CL fixes it. BUG=666860, 668456 Committed: https://crrev.com/1a60c807f31fa8546f0acdd63380c93be95b4807 Cr-Commit-Position: refs/heads/master@{#434785} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1a60c807f31fa8546f0acdd63380c93be95b4807 Cr-Commit-Position: refs/heads/master@{#434785} |
