Fix bugs in filtered event removal code

extensions/browser/event_router.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/event_router.h"
 
 #include <stddef.h>
 
 #include <tuple>
 #include <utility>
@@ skipping 401 matching lines @@
   ExtensionPrefs::ScopedDictionaryUpdate update(
       extension_prefs_, extension_id, kFilteredEvents);
   DictionaryValue* filtered_events = update.Get();
   ListValue* filter_list = NULL;
   if (!filtered_events ||
       !filtered_events->GetListWithoutPathExpansion(event_name, &filter_list)) {
     return;
   }
 
   for (size_t i = 0; i < filter_list->GetSize(); i++) {
-    DictionaryValue* filter = NULL;
-    CHECK(filter_list->GetDictionary(i, &filter));
-    if (filter->Equals(filter)) {
+    DictionaryValue* filter_value = NULL;
+    CHECK(filter_list->GetDictionary(i, &filter_value));
+    if (filter_value->Equals(filter)) {

[Devlin, 2016/11/24 01:21:32]

...

so this meant we were always removing the first filter whenever this was called?

[lazyboy, 2016/12/02 21:13:28]

*Almost*.
The fact that we had bug in writing those filtered events in prefs made this
Equals bug obscure.

       filter_list->Remove(i, NULL);
       break;
     }
   }
 }
 
 const DictionaryValue* EventRouter::GetFilteredEvents(
     const std::string& extension_id) {
   const DictionaryValue* events = NULL;
   extension_prefs_->ReadPrefAsDictionary(
@@ skipping 447 matching lines @@
                                      const std::string& extension_id,
                                      const GURL& listener_url,
                                      content::BrowserContext* browser_context)
     : event_name(event_name),
       extension_id(extension_id),
       listener_url(listener_url),
       browser_context(browser_context) {
 }
 
 }  // namespace extensions