Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2523903002: Document::updateHoverActiveState only cancel hover and active state when hitting native scrollbar (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index 5310a5bd9647c2fa2c37b82be06fa5f3442b2cd0..4c1960d0c007a6724d68610cd2243e911e2e2883 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -274,8 +274,9 @@ HitTestResult EventHandler::hitTestResultAtPoint(
m_frame->contentLayoutItem().hitTest(result);
if (!request.readOnly()) {
- m_frame->document()->updateHoverActiveState(request, result.innerElement(),
- result.scrollbar());
+ m_frame->document()->updateHoverActiveState(
+ request, result.innerElement(),
+ result.scrollbar() && result.scrollbar()->isOverlayScrollbar());
}
return result;
@@ -1858,8 +1859,9 @@ WebInputEventResult EventHandler::sendContextMenuEventForKey(
HitTestRequest request(HitTestRequest::Active);
HitTestResult result(request, locationInRootFrame);
result.setInnerNode(targetNode);
- doc->updateHoverActiveState(request, result.innerElement(),
- result.scrollbar());
+ doc->updateHoverActiveState(
+ request, result.innerElement(),
+ result.scrollbar() && result.scrollbar()->isOverlayScrollbar());
// The contextmenu event is a mouse event even when invoked using the
// keyboard. This is required for web compatibility.
@@ -1926,7 +1928,8 @@ void EventHandler::hoverTimerFired(TimerBase*) {
m_mouseEventManager->lastKnownMousePosition()));
layoutItem.hitTest(result);
m_frame->document()->updateHoverActiveState(
- request, result.innerElement(), result.scrollbar());
+ request, result.innerElement(),
+ result.scrollbar() && result.scrollbar()->isOverlayScrollbar());
}
}
}

Powered by Google App Engine
This is Rietveld 408576698