Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1552)

Issue 2523893002: Lazily allocate WSOLA structures; saves 56kB to 765kB of memory. (Closed)

Created:
4 years, 1 month ago by DaleCurtis
Modified:
4 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lazily allocate WSOLA structures; saves 56kB to 765kB of memory. These structures aren't needed until we actually attempt a playback rate adaptation, so don't bother allocating them until we do. This saves a few tens to hundreds of kilobytes of memory based on the channel layout. Stereo 48kHz: 57592 bytes Stereo 192kHz: 230392 bytes 7.1 48kHz: 195808 bytes 7.1 192kHz: 783328 bytes BUG=666813 TEST=none Committed: https://crrev.com/c9f01b2a8a5f2df7198f4c62faf9e6750451033a Cr-Commit-Position: refs/heads/master@{#434265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -36 lines) Patch
M media/filters/audio_renderer_algorithm.cc View 3 chunks +42 lines, -35 lines 0 comments Download
M media/filters/audio_renderer_algorithm_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
DaleCurtis
Also includes a minor test cleanup to make perf testing easier.
4 years, 1 month ago (2016-11-23 01:21:27 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years ago (2016-11-23 19:04:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523893002/1
4 years ago (2016-11-23 19:41:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 22:06:51 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-23 22:09:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9f01b2a8a5f2df7198f4c62faf9e6750451033a
Cr-Commit-Position: refs/heads/master@{#434265}

Powered by Google App Engine
This is Rietveld 408576698