Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 252383010: Call DOMWindow::finishedLoading from FrameLoader::checkLoadCompleteForThisFrame (Closed)

Created:
6 years, 8 months ago by Nate Chapin
Modified:
6 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, ojan, rwlbuis
Visibility:
Public.

Description

Call DOMWindow::finishedLoading from FrameLoader::checkLoadCompleteForThisFrame Currently, calling DOMWindow::finishedLoading is called from DocumentLoader's checkLoadComplete(), which is called from several different places. Just call finishedLoading() once, from FrameLoader::checkLoadCompleteForThisFrame. This also moves finishedLoading() to immediately after sending a didStopLoading to the embedder. Because DOMWindow::finishedLoading's primary purpose is to begin a page print, this ensures that print is not called until the embedder has been notified that the load has stopped. BUG=none, though the reorder might help resolve 365523 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nate Chapin
There's a failing browser test that depends on the ordering of stop and print, so ...
6 years, 8 months ago (2014-04-25 20:15:10 UTC) #1
abarth-chromium
If this works, LGTM!
6 years, 8 months ago (2014-04-25 20:57:11 UTC) #2
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 7 months ago (2014-04-28 19:19:25 UTC) #3
Nate Chapin
The CQ bit was unchecked by japhet@chromium.org
6 years, 7 months ago (2014-04-28 19:19:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/252383010/1
6 years, 7 months ago (2014-04-28 19:19:49 UTC) #5
Nate Chapin
The CQ bit was unchecked by japhet@chromium.org
6 years, 7 months ago (2014-04-28 19:20:14 UTC) #6
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 7 months ago (2014-04-29 20:10:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/252383010/1
6 years, 7 months ago (2014-04-29 20:26:31 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 03:38:45 UTC) #9
Message was sent while issue was closed.
Change committed as 172896

Powered by Google App Engine
This is Rietveld 408576698