Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 252383006: NameDictionary's key type is now Handle<Name> instead of Name*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/stub-cache-arm64.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 860 matching lines...) Expand 10 before | Expand all | Expand 10 after
871 871
872 prototype = handle(JSObject::cast(current_map->prototype())); 872 prototype = handle(JSObject::cast(current_map->prototype()));
873 if (current_map->is_dictionary_map() && 873 if (current_map->is_dictionary_map() &&
874 !current_map->IsJSGlobalObjectMap() && 874 !current_map->IsJSGlobalObjectMap() &&
875 !current_map->IsJSGlobalProxyMap()) { 875 !current_map->IsJSGlobalProxyMap()) {
876 if (!name->IsUniqueName()) { 876 if (!name->IsUniqueName()) {
877 ASSERT(name->IsString()); 877 ASSERT(name->IsString());
878 name = factory()->InternalizeString(Handle<String>::cast(name)); 878 name = factory()->InternalizeString(Handle<String>::cast(name));
879 } 879 }
880 ASSERT(current.is_null() || 880 ASSERT(current.is_null() ||
881 current->property_dictionary()->FindEntry(*name) == 881 current->property_dictionary()->FindEntry(name) ==
882 NameDictionary::kNotFound); 882 NameDictionary::kNotFound);
883 883
884 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, 884 GenerateDictionaryNegativeLookup(masm(), miss, reg, name,
885 scratch1, scratch2); 885 scratch1, scratch2);
886 886
887 __ mov(scratch1, FieldOperand(reg, HeapObject::kMapOffset)); 887 __ mov(scratch1, FieldOperand(reg, HeapObject::kMapOffset));
888 reg = holder_reg; // From now on the object will be in holder_reg. 888 reg = holder_reg; // From now on the object will be in holder_reg.
889 __ mov(reg, FieldOperand(scratch1, Map::kPrototypeOffset)); 889 __ mov(reg, FieldOperand(scratch1, Map::kPrototypeOffset));
890 } else { 890 } else {
891 bool in_new_space = heap()->InNewSpace(*prototype); 891 bool in_new_space = heap()->InNewSpace(*prototype);
(...skipping 676 matching lines...) Expand 10 before | Expand all | Expand 10 after
1568 // ----------------------------------- 1568 // -----------------------------------
1569 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1569 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1570 } 1570 }
1571 1571
1572 1572
1573 #undef __ 1573 #undef __
1574 1574
1575 } } // namespace v8::internal 1575 } } // namespace v8::internal
1576 1576
1577 #endif // V8_TARGET_ARCH_IA32 1577 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm64/stub-cache-arm64.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698