Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 252383006: NameDictionary's key type is now Handle<Name> instead of Name*. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

NameDictionary's key type is now Handle<Name> instead of Name*. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -57 lines) Patch
M src/arm/stub-cache-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/stub-cache-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 3 chunks +10 lines, -7 lines 0 comments Download
M src/objects.cc View 16 chunks +45 lines, -34 lines 0 comments Download
M src/objects-inl.h View 2 chunks +8 lines, -8 lines 0 comments Download
M src/runtime.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL. I should have been done this before handlification of Dictionary::Add() because otherwise it does ...
6 years, 8 months ago (2014-04-24 14:29:02 UTC) #1
Yang
On 2014/04/24 14:29:02, Igor Sheludko wrote: > PTAL. > > I should have been done ...
6 years, 8 months ago (2014-04-24 14:51:15 UTC) #2
Igor Sheludko
6 years, 8 months ago (2014-04-24 14:59:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698