Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 252383005: MIPS: CodeStubs contain their corresponding Isolate* now. (part 1) (Closed)

Created:
6 years, 8 months ago by kilvadyb
Modified:
6 years, 8 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: CodeStubs contain their corresponding Isolate* now. (part 1) Port r20919 (aa51355) Original commit message: This is a purely mechanical change, adding an Isolate* to the CodeStub constructor and a corresponding field plus a getter. A few methods in CodeStub and its subclasses can be simplified now, but this is done in a separate CL. The underlying reason apart from simplicity is that deep down in the call chain we need to detect if the serializer is active or not. This information will be part of the Isolate, not a global variable with funky synchronization primitives around it (which is fundamentally wrong and the underlying cause for race conditions and a catch-22 during initialization). BUG=359977 LOG=y

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -169 lines) Patch
M src/mips/builtins-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.h View 9 chunks +19 lines, -14 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 56 chunks +82 lines, -88 lines 0 comments Download
M src/mips/debug-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 27 chunks +30 lines, -26 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 2 chunks +8 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 14 chunks +24 lines, -20 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 9 chunks +11 lines, -9 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/stub-cache-mips.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-code-stubs-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
6 years, 8 months ago (2014-04-24 12:18:02 UTC) #1
Paul Lind
lgtm
6 years, 8 months ago (2014-04-24 14:39:45 UTC) #2
Paul Lind
6 years, 8 months ago (2014-04-24 14:43:09 UTC) #3
Committed as r20944.

Powered by Google App Engine
This is Rietveld 408576698