Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2523803003: [turbofan] Fix exception message for non-constructables. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix exception message for non-constructables. This fixes the message reported via the {TypeError} thrown when trying to call a non-constructable function as a constructor. Also adds some more related message tests for similar exceptions. R=bmeurer@chromium.org TEST=message/call-non-constructable BUG=chromium:661579 Committed: https://crrev.com/2b96c9d7c0fdcf3de62218498b738cc79567458f Cr-Commit-Position: refs/heads/master@{#41220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M src/compiler/js-call-reducer.cc View 1 chunk +2 lines, -1 line 0 comments Download
A test/message/call-non-constructable.js View 1 chunk +8 lines, -0 lines 0 comments Download
A test/message/call-non-constructable.out View 1 chunk +9 lines, -0 lines 0 comments Download
A test/message/call-primitive-constructor.js View 1 chunk +6 lines, -0 lines 0 comments Download
A test/message/call-primitive-constructor.out View 1 chunk +9 lines, -0 lines 0 comments Download
A test/message/call-primitive-function.js View 1 chunk +6 lines, -0 lines 0 comments Download
A test/message/call-primitive-function.out View 1 chunk +9 lines, -0 lines 0 comments Download
A test/message/call-undeclared-function.js View 1 chunk +5 lines, -0 lines 0 comments Download
A test/message/call-undeclared-function.out View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Starzinger
PTAL. Note that the "call-undeclared-constructor" test case is explicitly missing because there is a known ...
4 years ago (2016-11-23 12:44:24 UTC) #1
Benedikt Meurer
lgtm
4 years ago (2016-11-23 12:51:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523803003/1
4 years ago (2016-11-23 13:14:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 13:17:17 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-23 13:18:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b96c9d7c0fdcf3de62218498b738cc79567458f
Cr-Commit-Position: refs/heads/master@{#41220}

Powered by Google App Engine
This is Rietveld 408576698