Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Unified Diff: extensions/utility/utility_handler.cc

Issue 2523803002: Silence the overly verbose skipped files warning when extracting CRX files (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/zlib/google/zip.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/utility/utility_handler.cc
diff --git a/extensions/utility/utility_handler.cc b/extensions/utility/utility_handler.cc
index ac4d1d309215a01456b70cf177e2996e055bfe0d..59fcdfe38fdd35b144db044544da96cf92368c15 100644
--- a/extensions/utility/utility_handler.cc
+++ b/extensions/utility/utility_handler.cc
@@ -83,7 +83,8 @@ void UtilityHandler::OnUnzipToDir(const base::FilePath& zip_path,
const base::FilePath& dir) {
// First extract only the manifest to determine the extension type.
if (!zip::UnzipWithFilterCallback(zip_path, dir,
- base::Bind(&Unpacker::IsManifestFile))) {
+ base::Bind(&Unpacker::IsManifestFile),
+ false /* log_skipped_files */)) {
Send(new ExtensionUtilityHostMsg_UnzipToDir_Failed(
std::string(kExtensionHandlerUnzipError)));
ReleaseProcessIfNeeded();
@@ -107,7 +108,8 @@ void UtilityHandler::OnUnzipToDir(const base::FilePath& zip_path,
// TODO(crbug.com/645263): This silently ignores blocked file types.
// Add install warnings.
- if (!zip::UnzipWithFilterCallback(zip_path, dir, filetype_filter_cb)) {
+ if (!zip::UnzipWithFilterCallback(zip_path, dir, filetype_filter_cb,
+ true /* log_skipped_files */)) {
Send(new ExtensionUtilityHostMsg_UnzipToDir_Failed(
std::string(kExtensionHandlerUnzipError)));
} else {
« no previous file with comments | « no previous file | third_party/zlib/google/zip.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698