Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: net/test/embedded_test_server/embedded_test_server.cc

Issue 25238003: Will now DCHECK that test writers start the embedded server before using it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing tests which did not init embedded test server Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/embedded_test_server/embedded_test_server.cc
diff --git a/net/test/embedded_test_server/embedded_test_server.cc b/net/test/embedded_test_server/embedded_test_server.cc
index 07bad2813faeb12596bfbeab6c32cdb00ae500d0..128597f20e8f80cb2a5bd202c4b03d9a7327a188 100644
--- a/net/test/embedded_test_server/embedded_test_server.cc
+++ b/net/test/embedded_test_server/embedded_test_server.cc
@@ -196,6 +196,7 @@ void EmbeddedTestServer::HandleRequest(HttpConnection* connection,
}
GURL EmbeddedTestServer::GetURL(const std::string& relative_url) const {
+ DCHECK(Started()) << "You must start the server first.";
DCHECK(StartsWithASCII(relative_url, "/", true /* case_sensitive */))
<< relative_url;
return base_url_.Resolve(relative_url);
« no previous file with comments | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698