chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc - Issue 2523783002: Top Chrome MD cleanup - get rid of most of GetLayoutInsets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc

Issue 2523783002: Top Chrome MD cleanup - get rid of most of GetLayoutInsets. (Closed)

Patch Set: fix typo Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc

diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc

index e6e043416db795cfcc80b46e0c6ec1bfff8c89cc..156121c915ac1c008b35cafb53cd3d1d5af5ee3b 100644

--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc

+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc

@@ -236,7 +236,7 @@ class OpaqueBrowserFrameViewLayoutTest : public views::ViewsTestBase {

(maximized ? OBFVL::kCaptionSpacing

: -GetLayoutSize(NEW_TAB_BUTTON).width());

}

- int tabstrip_x = GetLayoutInsets(AVATAR_ICON).right();

+ int tabstrip_x = GetLayoutConstant(AVATAR_ICON_PADDING);

if (show_caption_buttons && caption_buttons_on_left) {

int right_of_close =

maximized ? kMaximizedExtraCloseWidth : OBFVL::kFrameBorderThickness;