Top Chrome MD cleanup - get rid of most of GetLayoutInsets.

chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
index 04bb74bcb783ba4cd6281b2a1d5d38b63aed88aa..d6d30558582fb3810627bc3970545193c5bbc057 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
@@ -38,6 +38,8 @@ namespace {
 base::LazyInstance<gfx::ImageSkia> g_top_shadow = LAZY_INSTANCE_INITIALIZER;
 base::LazyInstance<gfx::ImageSkia> g_bottom_shadow = LAZY_INSTANCE_INITIALIZER;
 
+const int kPopupVerticalPadding = 4;
+
 }  // namespace
 
 class OmniboxPopupContentsView::AutocompletePopupWidget
@@ -147,7 +149,7 @@ gfx::Rect OmniboxPopupContentsView::GetPopupBounds() const {
 
 void OmniboxPopupContentsView::LayoutChildren() {
   gfx::Rect contents_rect = GetContentsBounds();
-  contents_rect.Inset(GetLayoutInsets(OMNIBOX_DROPDOWN));
+  contents_rect.Inset(gfx::Insets(kPopupVerticalPadding, 0));

[Peter Kasting, 2016/11/22 22:12:08]

Nit: contents_rect.Inset(0, kPopupVerticalPadding);

[Evan Stade, 2016/11/29 03:01:45]

I strongly dislike that Rect's Inset methods mess with the order of parameters*,
so I try to avoid ever using them and hope one day to delete them (just leaving
the gfx::Insets version). I am confident this difference causes unmentioned
headaches if not outright bugs, and I am constantly in fear of making the
mistake every time I deal with insets because I can never quite remember which
method it is that rearranges the arguments. 

*compared to gfx::Insets and the Border factory functions

   contents_rect.Inset(start_margin_, g_top_shadow.Get().height(), end_margin_,
                       0);
 
@@ -434,7 +436,7 @@ int OmniboxPopupContentsView::CalculatePopupHeight() {
   // Add enough space on the top and bottom so it looks like there is the same
   // amount of space between the text and the popup border as there is in the
   // interior between each row of text.
-  return popup_height + GetLayoutInsets(OMNIBOX_DROPDOWN).height() +
+  return popup_height + kPopupVerticalPadding * 2 +
          g_top_shadow.Get().height() + g_bottom_shadow.Get().height();
 }