Top Chrome MD cleanup - get rid of most of GetLayoutInsets.

chrome/browser/ui/views/frame/glass_browser_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/glass_browser_frame_view.h"
 
 #include <dwmapi.h>
 #include <utility>
 
 #include "base/win/windows_version.h"
@@ skipping 122 matching lines @@
 
 GlassBrowserFrameView::~GlassBrowserFrameView() {
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // GlassBrowserFrameView, BrowserNonClientFrameView implementation:
 
 gfx::Rect GlassBrowserFrameView::GetBoundsForTabStrip(
     views::View* tabstrip) const {
   const int x =
-      incognito_bounds_.right() + GetLayoutInsets(AVATAR_ICON).right();
+      incognito_bounds_.right() + GetLayoutConstant(AVATAR_ICON_PADDING);
   int end_x = width() - ClientBorderThickness(false);
   if (!CaptionButtonsOnLeadingEdge()) {
     end_x = std::min(MinimizeButtonX(), end_x) -
             (IsMaximized() ? kNewTabCaptionMaximizedSpacing
                            : kNewTabCaptionRestoredSpacing);
 
     // The profile switcher button is optionally displayed to the left of the
     // minimize button.
     if (profile_switcher_.view()) {
       const int old_end_x = end_x;
@@ skipping 578 matching lines @@
     // their contents are aligned as if they were 20 pixels high and extended
     // 1 pixel off the top of the screen. We position the profile switcher
     // button the same way to match.
     button_y -= 1;
   }
   profile_switcher_.view()->SetBounds(button_x, button_y, label_size.width(),
                                       kProfileSwitcherButtonHeight);
 }
 
 void GlassBrowserFrameView::LayoutIncognitoIcon() {
-  const gfx::Insets insets(GetLayoutInsets(AVATAR_ICON));
+  const int pad = GetLayoutConstant(AVATAR_ICON_PADDING);
   const gfx::Size size(GetIncognitoAvatarIcon().size());
   int x = ClientBorderThickness(false);
   // In RTL, the icon needs to start after the caption buttons.
   if (CaptionButtonsOnLeadingEdge()) {
     x = width() - frame()->GetMinimizeButtonOffset() +
         (profile_switcher_.view() ? (profile_switcher_.view()->width() +
                                      kProfileSwitcherButtonOffset)
                                   : 0);
   }
-  const int bottom = GetTopInset(false) + browser_view()->GetTabStripHeight() -
-                     insets.bottom();
-  incognito_bounds_.SetRect(x + (profile_indicator_icon() ? insets.left() : 0),
-                            bottom - size.height(),
-                            profile_indicator_icon() ? size.width() : 0,
-                            size.height());
+  const int bottom =
+      GetTopInset(false) + browser_view()->GetTabStripHeight() - pad;
+  incognito_bounds_.SetRect(
+      x + (profile_indicator_icon() ? pad : 0), bottom - size.height(),
+      profile_indicator_icon() ? size.width() : 0, size.height());
   if (profile_indicator_icon())
     profile_indicator_icon()->SetBoundsRect(incognito_bounds_);
 }
 
 void GlassBrowserFrameView::LayoutTitleBar() {
   if (!ShowCustomIcon() && !ShowCustomTitle())
     return;
 
   gfx::Rect window_icon_bounds;
   const int icon_size =
@@ skipping 143 matching lines @@
   static bool initialized = false;
   if (!initialized) {
     for (int i = 0; i < kThrobberIconCount; ++i) {
       throbber_icons_[i] =
           ui::LoadThemeIconFromResourcesDataDLL(IDI_THROBBER_01 + i);
       DCHECK(throbber_icons_[i]);
     }
     initialized = true;
   }
 }