Add inputmode to android ImeAdapater.

Add inputmode to android ImeAdapater.

When an inputmode is specified it overrides the default text input type.
inputmode is behind an experimental web platform flag but it allows
the author to configure what virtual keyboard is shown for the various
input and content editable fields.

BUG=642800
TBR=aelias@chromium.org

Committed: https://crrev.com/d82b0b1856c7982bac88fdc12f40752b1191be81
Cr-Commit-Position: refs/heads/master@{#434804}

[dtapuska, 2016-11-22 17:59:56]

dtapuska@chromium.org changed reviewers:
+ aelias@chromium.org, tedchoc@chromium.org

[dtapuska, 2016-11-22 18:00:05]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 18:00:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 18:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 18:23:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dtapuska, 2016-11-22 19:19:36]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 19:20:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-11-22 19:33:03]

Description was changed from

==========
Add inputmode to android ImeAdapater.

When an inputmode is specified it overrides the default text input type.
inputmode is behind an experimental web platform flag but it allows
the author to configure what virtual keyboard is shown for the various
input and content editable fields.

BUG=642800
==========

to

==========
Add inputmode to android ImeAdapater.

When an inputmode is specified it overrides the default text input type.
inputmode is behind an experimental web platform flag but it allows
the author to configure what virtual keyboard is shown for the various
input and content editable fields.

BUG=642800
==========

[dtapuska, 2016-11-22 19:33:03]

dtapuska@chromium.org changed reviewers:
+ changwan@chromium.org
- aelias@chromium.org

[commit-bot: I haz the power, 2016-11-22 21:55:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 21:55:09]

Dry run: This issue passed the CQ dry run.

[Changwan Ryu, 2016-11-24 03:19:19]

Hmm... I'm afraid that the only scenario this can be beneficial in reality is
when you want to apply rich text editing for non-text input, e.g.
number/tel/email/URL. But as the spec says, tel/email/url are "rarely
necessary". So I'm not sure what benefit a user can get from the added logic.

As for Latin and Japanese specs, I don't think they can scale anyways, but is
there any OS that does or plans to support those types?

[Changwan Ryu, 2016-11-24 03:52:15]

On 2016/11/24 03:19:19, Changwan Ryu wrote:
> Hmm... I'm afraid that the only scenario this can be beneficial in reality is
> when you want to apply rich text editing for non-text input, e.g.
> number/tel/email/URL. But as the spec says, tel/email/url are "rarely
> necessary". So I'm not sure what benefit a user can get from the added logic.
> 
> As for Latin and Japanese specs, I don't think they can scale anyways, but is
> there any OS that does or plans to support those types?

Ok, I read your proposal @
https://rawgit.com/dtapuska/inputmode/master/index.html
and the discussion @ https://github.com/whatwg/html/issues/1897.

Windows seems to support those language specific properties, so that alone
justifies
spec conformity, let alone contenteditable scenarios.

input/ lgtm

[dtapuska, 2016-11-24 14:25:52]

On 2016/11/24 03:52:15, Changwan Ryu wrote:
> On 2016/11/24 03:19:19, Changwan Ryu wrote:
> > Hmm... I'm afraid that the only scenario this can be beneficial in reality
is
> > when you want to apply rich text editing for non-text input, e.g.
> > number/tel/email/URL. But as the spec says, tel/email/url are "rarely
> > necessary". So I'm not sure what benefit a user can get from the added
logic.
> > 
> > As for Latin and Japanese specs, I don't think they can scale anyways, but
is
> > there any OS that does or plans to support those types?
> 
> Ok, I read your proposal @
> https://rawgit.com/dtapuska/inputmode/master/index.html
> and the discussion @ https://github.com/whatwg/html/issues/1897.
> 
> Windows seems to support those language specific properties, so that alone
> justifies
> spec conformity, let alone contenteditable scenarios.
> 
> input/ lgtm

It's beneficial for polymer which is going to stop using input fields and start
using contenteditable.

[dtapuska, 2016-11-28 15:59:12]

dtapuska@chromium.org changed reviewers:
+ rbyers@chromium.org

[dtapuska, 2016-11-28 15:59:12]

rbyers@chromium.org: Please review changes in 

third_party/WebKit/public/*

[Ted C, 2016-11-28 16:59:53]

On 2016/11/28 15:59:12, dtapuska wrote:
> mailto:rbyers@chromium.org: Please review changes in 
> 
> third_party/WebKit/public/*

lgtm for remainder of android changes

[Rick Byers, 2016-11-28 18:38:05]

On 2016/11/28 15:59:12, dtapuska wrote:
> mailto:rbyers@chromium.org: Please review changes in 
> 
> third_party/WebKit/public/*

public/ LGTM

[dtapuska, 2016-11-28 18:45:17]

Description was changed from

==========
Add inputmode to android ImeAdapater.

When an inputmode is specified it overrides the default text input type.
inputmode is behind an experimental web platform flag but it allows
the author to configure what virtual keyboard is shown for the various
input and content editable fields.

BUG=642800
==========

to

==========
Add inputmode to android ImeAdapater.

When an inputmode is specified it overrides the default text input type.
inputmode is behind an experimental web platform flag but it allows
the author to configure what virtual keyboard is shown for the various
input and content editable fields.

BUG=642800
TBR=aelias@chromium.org
==========

[dtapuska, 2016-11-28 18:45:17]

dtapuska@chromium.org changed reviewers:
+ aelias@chromium.org

[dtapuska, 2016-11-28 18:45:27]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-11-28 18:45:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 18:51:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 18:51:07]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dtapuska, 2016-11-28 18:59:34]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 19:00:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 20:22:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:22:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[dtapuska, 2016-11-28 23:37:37]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-11-28 23:37:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, changwan@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2523753003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-28 23:39:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 00:51:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480376257315260,
"parent_rev": "bef5f76a4f27f6fb49edce726d14a477c84645a1", "commit_rev":
"707e0b59ee890ce5b4a3f6a18ef92b9342b85849"}

[commit-bot: I haz the power, 2016-11-29 00:52:19]

Description was changed from

==========
Add inputmode to android ImeAdapater.

When an inputmode is specified it overrides the default text input type.
inputmode is behind an experimental web platform flag but it allows
the author to configure what virtual keyboard is shown for the various
input and content editable fields.

BUG=642800
TBR=aelias@chromium.org
==========

to

==========
Add inputmode to android ImeAdapater.

When an inputmode is specified it overrides the default text input type.
inputmode is behind an experimental web platform flag but it allows
the author to configure what virtual keyboard is shown for the various
input and content editable fields.

BUG=642800
TBR=aelias@chromium.org
==========

[commit-bot: I haz the power, 2016-11-29 00:52:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-29 00:55:59]

Description was changed from

==========
Add inputmode to android ImeAdapater.

When an inputmode is specified it overrides the default text input type.
inputmode is behind an experimental web platform flag but it allows
the author to configure what virtual keyboard is shown for the various
input and content editable fields.

BUG=642800
TBR=aelias@chromium.org
==========

to

==========
Add inputmode to android ImeAdapater.

When an inputmode is specified it overrides the default text input type.
inputmode is behind an experimental web platform flag but it allows
the author to configure what virtual keyboard is shown for the various
input and content editable fields.

BUG=642800
TBR=aelias@chromium.org

Committed: https://crrev.com/d82b0b1856c7982bac88fdc12f40752b1191be81
Cr-Commit-Position: refs/heads/master@{#434804}
==========

[commit-bot: I haz the power, 2016-11-29 00:56:00]

Patchset 3 (id:??) landed as
https://crrev.com/d82b0b1856c7982bac88fdc12f40752b1191be81
Cr-Commit-Position: refs/heads/master@{#434804}