Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2523743004: Ensure CPDF_CountedObjects only made from owned references. (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Ensure CPDF_CountedObjects only made from owned references. Deletion of said object is still inflicted on the callers. But that's an issue for another day. Committed: https://pdfium.googlesource.com/pdfium/+/6136ec6347a5858a85912a805ea41126863558cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -31 lines) Patch
M core/fpdfapi/page/cpdf_countedobject.h View 2 chunks +6 lines, -3 lines 0 comments Download
M core/fpdfapi/page/cpdf_docpagedata.cpp View 8 chunks +27 lines, -24 lines 0 comments Download
M core/fpdfapi/render/cpdf_docrenderdata.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Lei, for review.
4 years ago (2016-11-22 20:11:53 UTC) #2
Lei Zhang
lgtm
4 years ago (2016-11-22 20:47:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523743004/1
4 years ago (2016-11-22 21:01:26 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-22 21:01:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6136ec6347a5858a85912a805ea411268635...

Powered by Google App Engine
This is Rietveld 408576698