Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2523683003: s390: using correct type to fix gcc error (Closed)

Created:
4 years ago by JaideepBajwa
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: using correct type to fix gcc error Wsign-compare exposed this error in s390 31-bit debug build. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Committed: https://crrev.com/23193d394f37b890b74ae204026fdecd7aa96bc2 Cr-Commit-Position: refs/heads/master@{#41200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M src/s390/simulator-s390.cc View 3 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
4 years ago (2016-11-23 04:32:24 UTC) #1
john.yan
lgtm
4 years ago (2016-11-23 04:34:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523683003/1
4 years ago (2016-11-23 04:42:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 05:05:12 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-23 05:05:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23193d394f37b890b74ae204026fdecd7aa96bc2
Cr-Commit-Position: refs/heads/master@{#41200}

Powered by Google App Engine
This is Rietveld 408576698