Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2523683002: Update tests which are now failing with FLAG_lazy_inner_functions. (Closed)

Created:
4 years, 1 month ago by marja
Modified:
4 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update tests which are now failing with FLAG_lazy_inner_functions. The tests were relying on early errors which we don't produce since we now preparse more often. BUG=v8:2728, v8:5501, v8:5663 Committed: https://crrev.com/0f87349505a968e438736eb7d6cdcf0ea62d3d0b Cr-Commit-Position: refs/heads/master@{#41189}

Patch Set 1 #

Patch Set 2 : flag on #

Patch Set 3 : flag off #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -12 lines) Patch
M test/mjsunit/bugs/bug-2728.js View 1 chunk +18 lines, -0 lines 0 comments Download
M test/mjsunit/es6/destructuring.js View 1 chunk +5 lines, -4 lines 0 comments Download
M test/mjsunit/es6/generator-destructuring.js View 1 chunk +5 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/async-destructuring.js View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
marja
ptal
4 years, 1 month ago (2016-11-22 14:07:52 UTC) #10
Toon Verwaest
lgtm
4 years, 1 month ago (2016-11-22 15:09:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523683002/80001
4 years, 1 month ago (2016-11-22 15:22:08 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 1 month ago (2016-11-22 15:45:58 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 15:46:24 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0f87349505a968e438736eb7d6cdcf0ea62d3d0b
Cr-Commit-Position: refs/heads/master@{#41189}

Powered by Google App Engine
This is Rietveld 408576698