Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2523673002: Add a test for multiple >>>s in a selector. (Closed)

Created:
4 years, 1 month ago by kochi
Modified:
4 years ago
Reviewers:
hayato, rune
CC:
chromium-reviews, blink-reviews, rune, Timothy Loh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for multiple >>>s in a selector. Add a test case for matching multiple '>>>' (shadow-piercing descendant combinator)s. BUG=633007 Committed: https://crrev.com/23e53e844095c53dfa18d0b30b04f577c25cb897 Cr-Commit-Position: refs/heads/master@{#434339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/shadow-piercing-descendant-combinator.html View 3 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 35 (21 generated)
kochi
PTAL
4 years, 1 month ago (2016-11-22 10:21:34 UTC) #4
rune
lgtm
4 years, 1 month ago (2016-11-22 12:03:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523673002/1
4 years ago (2016-11-24 00:13:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 02:15:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523673002/1
4 years ago (2016-11-24 02:34:14 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on ...
4 years ago (2016-11-24 04:35:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523673002/1
4 years ago (2016-11-24 04:40:29 UTC) #19
commit-bot: I haz the power
Exceeded global retry quota
4 years ago (2016-11-24 06:41:47 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523673002/1
4 years ago (2016-11-24 08:26:08 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523673002/1
4 years ago (2016-11-24 12:15:20 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 14:17:27 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523673002/1
4 years ago (2016-11-24 15:30:36 UTC) #30
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 16:26:28 UTC) #33
commit-bot: I haz the power
4 years ago (2016-11-24 16:28:41 UTC) #35
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23e53e844095c53dfa18d0b30b04f577c25cb897
Cr-Commit-Position: refs/heads/master@{#434339}

Powered by Google App Engine
This is Rietveld 408576698