Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2933)

Unified Diff: appengine/findit/findit_api.py

Issue 2523633004: [Findit] fix exception in endpoint for alerts-dispatcher. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/findit_api.py
diff --git a/appengine/findit/findit_api.py b/appengine/findit/findit_api.py
index 3cda11ae9f0a4a7adcc8a8395f265b4ab4455347..627777ecb756236053f0a898a2e022b51b9f4f0b 100644
--- a/appengine/findit/findit_api.py
+++ b/appengine/findit/findit_api.py
@@ -173,7 +173,7 @@ class FindItApi(remote.Service):
# If the CL is found by a try job, only the first failure will be recorded.
# So we might need to go to the first failure to get CL information.
build_info = cl.GetBuildInfo(master_name, builder_name, current_build)
- first_build_info = cl.GetBuildInfo(
+ first_build_info = None if not reference_build_key else cl.GetBuildInfo(
*build_util.GetBuildInfoFromId(reference_build_key))
return suspected_cl_util.GetSuspectedCLConfidenceScoreAndApproach(
confidences, build_info, first_build_info)
@@ -409,7 +409,6 @@ class FindItApi(remote.Service):
self._GetSwarmingTaskAndTryJobForFailure(
step_name, test_name, heuristic_analysis.failure_result_map,
swarming_tasks, try_jobs))
-
self._PopulateResult(
results, build, heuristic_analysis.failure_type, test,
step_name, confidences, reference_build_key, swarming_task,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698