Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2523633003: [Devtools] Prepare network log view for grouping support (Closed)
Patch Set: Merge branch 'master' into NETWORK_GROUP_SUPPORT_1 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index ab943236014e4742f731770c9359d4847986de92..5bb378a6c6b752485774a40e811509ac27871b30 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -261,17 +261,33 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
/**
* @override
+ * @return {boolean}
+ */
+ isGroup() {
+ return false;
+ }
+
+ /**
+ * @override
* @return {!SDK.NetworkRequest}
*/
- request() {
+ firstRequest() {
dgozman 2016/11/23 01:57:30 Why firstRequest, and not a request?
allada 2016/11/23 22:39:14 Done.
return this._request;
}
/**
* @override
+ * @return {!Array<!SDK.NetworkRequest>}
+ */
+ requests() {
+ return [this._request];
+ }
+
+ /**
+ * @override
* @return {boolean}
*/
- isNavigationRequest() {
+ hasNavigationRequest() {
return this._isNavigationRequest;
}
@@ -612,12 +628,22 @@ Network.NetworkLogEntry = function() {};
Network.NetworkLogEntry.prototype = {
/**
- * @return {!SDK.NetworkRequest}
+ * @return {?SDK.NetworkRequest}
+ */
+ firstRequest() {},
+
+ /**
+ * @return {!Array<!SDK.NetworkRequest>}
+ */
+ requests() {},
+
+ /**
+ * @return {boolean}
*/
- request() {},
+ hasNavigationRequest() {},
/**
* @return {boolean}
*/
- isNavigationRequest() {}
+ isGroup() {}
};

Powered by Google App Engine
This is Rietveld 408576698