third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js - Issue 2523633003: [Devtools] Prepare network log view for grouping support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2523633003: [Devtools] Prepare network log view for grouping support (Closed)

Patch Set: fixed request === null and possible filter out issue Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

index 6fb1f1373176b0bd539267fe7691776380ec1de7..1fb61b3788765b3f4753d9b1807933a3d3c03db9 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

@@ -157,7 +157,7 @@ Network.NetworkLogViewColumns = class {

if (!node)

return;

var contextMenu = new UI.ContextMenu(event);

- this._networkLogView.handleContextMenuForRequest(contextMenu, node.request());

+ this._networkLogView.handleContextMenuForNode(contextMenu, node);

contextMenu.show();

}

@@ -198,7 +198,7 @@ Network.NetworkLogViewColumns = class {

this._activeScroller.scrollTop, this._eventDividersShown ? this._eventDividers : undefined);

return;

}

- var nodes = this._networkLogView.flatNodesList();

+ var nodes = this._networkLogView.flattenVisibleNodes();

this._waterfallColumn.update(this._activeScroller.scrollTop, this._eventDividers, nodes);

}