Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2523633003: [Devtools] Prepare network log view for grouping support (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index ab943236014e4742f731770c9359d4847986de92..34631b4d55ecf3d3efe2c25c71c11d7dc0ccd97e 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -29,7 +29,6 @@
*/
/**
- * @implements {Network.NetworkLogEntry}
* @unrestricted
*/
Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
@@ -260,7 +259,6 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
}
/**
- * @override
* @return {!SDK.NetworkRequest}
*/
request() {
@@ -268,10 +266,22 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
}
/**
- * @override
+ * @return {!Array<!SDK.NetworkRequest>}
+ */
+ requests() {
+ var requests = [this._request];
+ for (var node of this.flattenChildren(true)) {
+ var request = node.request();
+ if (request)
+ requests.push(request);
+ }
+ return requests;
+ }
+
+ /**
* @return {boolean}
*/
- isNavigationRequest() {
+ hasNavigationRequest() {
return this._isNavigationRequest;
}
@@ -604,20 +614,3 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
cellElement.appendChild(subtitleElement);
}
};
-
-/**
- * @interface
- */
-Network.NetworkLogEntry = function() {};
-
-Network.NetworkLogEntry.prototype = {
- /**
- * @return {!SDK.NetworkRequest}
- */
- request() {},
-
- /**
- * @return {boolean}
- */
- isNavigationRequest() {}
-};

Powered by Google App Engine
This is Rietveld 408576698