Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js |
| index ab943236014e4742f731770c9359d4847986de92..15aa11ac15a1ad0998e78c5337b79a49fdc0560d 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js |
| @@ -269,9 +269,23 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode { |
| /** |
| * @override |
| + * @return {!Array<!SDK.NetworkRequest>} |
| + */ |
| + requests() { |
| + var requests = [this._request]; |
| + for (var node of this.flatenChildren()) { |
|
dgozman
2016/11/28 18:39:51
This looks so inefficient.
allada
2016/11/29 00:35:09
This call is cached so it should not be bad.
|
| + var request = node.request(); |
| + if (request) |
| + requests.push(request); |
| + } |
| + return requests; |
| + } |
| + |
| + /** |
| + * @override |
| * @return {boolean} |
| */ |
| - isNavigationRequest() { |
| + hasNavigationRequest() { |
| return this._isNavigationRequest; |
| } |
| @@ -612,12 +626,22 @@ Network.NetworkLogEntry = function() {}; |
| Network.NetworkLogEntry.prototype = { |
| /** |
| - * @return {!SDK.NetworkRequest} |
| + * @return {?SDK.NetworkRequest} |
| */ |
| request() {}, |
| /** |
| + * @return {!Array<!SDK.NetworkRequest>} |
| + */ |
| + requests() {}, |
| + |
| + /** |
| + * @return {boolean} |
| + */ |
| + hasNavigationRequest() {}, |
| + |
| + /** |
| * @return {boolean} |
| */ |
| - isNavigationRequest() {} |
| + get hasChildren() {} |
|
dgozman
2016/11/28 18:39:51
No getters please...
allada
2016/11/29 00:35:09
Done.
|
| }; |