Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2523633003: [Devtools] Prepare network log view for grouping support (Closed)
Patch Set: fixed request === null and possible filter out issue Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Network.NetworkLogViewColumns = class { 7 Network.NetworkLogViewColumns = class {
8 /** 8 /**
9 * @param {!Network.NetworkLogView} networkLogView 9 * @param {!Network.NetworkLogView} networkLogView
10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator 10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 150
151 /** 151 /**
152 * @param {!Event} event 152 * @param {!Event} event
153 * @this {Network.NetworkLogViewColumns} 153 * @this {Network.NetworkLogViewColumns}
154 */ 154 */
155 function handleContextMenu(event) { 155 function handleContextMenu(event) {
156 var node = this._waterfallColumn.getNodeFromPoint(event.offsetX, event.off setY); 156 var node = this._waterfallColumn.getNodeFromPoint(event.offsetX, event.off setY);
157 if (!node) 157 if (!node)
158 return; 158 return;
159 var contextMenu = new UI.ContextMenu(event); 159 var contextMenu = new UI.ContextMenu(event);
160 this._networkLogView.handleContextMenuForRequest(contextMenu, node.request ()); 160 this._networkLogView.handleContextMenuForNode(contextMenu, node);
161 contextMenu.show(); 161 contextMenu.show();
162 } 162 }
163 } 163 }
164 164
165 /** 165 /**
166 * @param {boolean} shouldConsume 166 * @param {boolean} shouldConsume
167 * @param {!Event} event 167 * @param {!Event} event
168 */ 168 */
169 _onMouseWheel(shouldConsume, event) { 169 _onMouseWheel(shouldConsume, event) {
170 if (shouldConsume) 170 if (shouldConsume)
(...skipping 20 matching lines...) Expand all
191 } 191 }
192 } 192 }
193 193
194 _redrawWaterfallColumn() { 194 _redrawWaterfallColumn() {
195 if (!this._waterfallRequestsAreStale) { 195 if (!this._waterfallRequestsAreStale) {
196 this._updateScrollerWidthIfNeeded(); 196 this._updateScrollerWidthIfNeeded();
197 this._waterfallColumn.update( 197 this._waterfallColumn.update(
198 this._activeScroller.scrollTop, this._eventDividersShown ? this._event Dividers : undefined); 198 this._activeScroller.scrollTop, this._eventDividersShown ? this._event Dividers : undefined);
199 return; 199 return;
200 } 200 }
201 var nodes = this._networkLogView.flatNodesList(); 201 var nodes = this._networkLogView.flattenVisibleNodes();
202 this._waterfallColumn.update(this._activeScroller.scrollTop, this._eventDivi ders, nodes); 202 this._waterfallColumn.update(this._activeScroller.scrollTop, this._eventDivi ders, nodes);
203 } 203 }
204 204
205 /** 205 /**
206 * @param {?Network.NetworkDataGridNode} node 206 * @param {?Network.NetworkDataGridNode} node
207 * @param {boolean} highlightInitiatorChain 207 * @param {boolean} highlightInitiatorChain
208 */ 208 */
209 setHoveredNode(node, highlightInitiatorChain) { 209 setHoveredNode(node, highlightInitiatorChain) {
210 this._waterfallColumn.setHoveredNode(node, highlightInitiatorChain); 210 this._waterfallColumn.setHoveredNode(node, highlightInitiatorChain);
211 } 211 }
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
817 /** 817 /**
818 * @enum {string} 818 * @enum {string}
819 */ 819 */
820 Network.NetworkLogViewColumns.WaterfallSortIds = { 820 Network.NetworkLogViewColumns.WaterfallSortIds = {
821 StartTime: 'startTime', 821 StartTime: 'startTime',
822 ResponseTime: 'responseReceivedTime', 822 ResponseTime: 'responseReceivedTime',
823 EndTime: 'endTime', 823 EndTime: 'endTime',
824 Duration: 'duration', 824 Duration: 'duration',
825 Latency: 'latency' 825 Latency: 'latency'
826 }; 826 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698