Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2523603002: Merge to M56: Trigger redirect for offline pages (Closed)

Created:
4 years, 1 month ago by jianli
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge to M56: Trigger redirect for offline pages If original request URL is found, we will use it to trigger redirect such that offline page for final redirected URL could be served. BUG=618716 Review-Url: https://codereview.chromium.org/2506293002 Cr-Commit-Position: refs/heads/master@{#433318} (cherry picked from commit 55994375eb39e2965999474fb3612737626bed13) Committed: https://chromium.googlesource.com/chromium/src/+/1210efb30b84501b546b16a45a3a8c544ebd7f3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -5 lines) Patch
M chrome/browser/android/offline_pages/offline_page_request_job.h View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job.cc View 3 chunks +64 lines, -2 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc View 7 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jianli
4 years, 1 month ago (2016-11-22 01:13:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1210efb30b84501b546b16a45a3a8c544ebd7f3e.

Powered by Google App Engine
This is Rietveld 408576698