Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2523593002:
Strip invalid utf-8 characters from mc.exe header output (Closed)
DescriptionStrip invalid utf-8 characters from mc.exe header output
R=brettw@chromium.org
BUG=454858, 637203
Committed: https://crrev.com/7fff8524e1dc70a10e330b659acddf5ed72eee5f
Cr-Commit-Position: refs/heads/master@{#433898}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 15 (7 generated)
Description was changed from ========== Strip invalid utf-8 characters from mc.exe header output BUG=454858, 637203 ========== to ========== Strip invalid utf-8 characters from mc.exe header output R=brettw@chromium.org BUG=454858, 637203 ==========
scottmg@chromium.org changed reviewers: + brettw@chromium.org
:( LGTM
On 2016/11/22 05:02:09, brettw (ping on IM after 24h) wrote: > :( LGTM Yup.
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479832040119470, "parent_rev":
"fe9a1d630b9c7a01fc5d7d85858925e47773c0ec", "commit_rev":
"1d6f52146361226803d115b3af8e3f8099cb8238"}
Message was sent while issue was closed.
Description was changed from ========== Strip invalid utf-8 characters from mc.exe header output R=brettw@chromium.org BUG=454858, 637203 ========== to ========== Strip invalid utf-8 characters from mc.exe header output R=brettw@chromium.org BUG=454858, 637203 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Strip invalid utf-8 characters from mc.exe header output R=brettw@chromium.org BUG=454858, 637203 ========== to ========== Strip invalid utf-8 characters from mc.exe header output R=brettw@chromium.org BUG=454858, 637203 Committed: https://crrev.com/7fff8524e1dc70a10e330b659acddf5ed72eee5f Cr-Commit-Position: refs/heads/master@{#433898} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7fff8524e1dc70a10e330b659acddf5ed72eee5f Cr-Commit-Position: refs/heads/master@{#433898}
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2523593002/diff/1/build/win/message_compiler.py File build/win/message_compiler.py (right): https://codereview.chromium.org/2523593002/diff/1/build/win/message_compiler.... build/win/message_compiler.py:37: # // comment lines, we simply drop the line in the header after building it. (did you file an msconnect for getting support for this in mc.exe in the future?)
Message was sent while issue was closed.
On 2016/11/22 17:45:21, Nico wrote: > https://codereview.chromium.org/2523593002/diff/1/build/win/message_compiler.py > File build/win/message_compiler.py (right): > > https://codereview.chromium.org/2523593002/diff/1/build/win/message_compiler.... > build/win/message_compiler.py:37: # // comment lines, we simply drop the line in > the header after building it. > (did you file an msconnect for getting support for this in mc.exe in the > future?) I suppose it's not impossible. https://connect.microsoft.com/VisualStudio/feedback/details/3112791 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
