third_party/inspector_protocol/lib/Object_h.template - Issue 2523583005: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/inspector_protocol/lib/Object_h.template

Issue 2523583005: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48 (Closed)

Patch Set: added default implementation Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/inspector_protocol/lib/Object_h.template

diff --git a/third_party/inspector_protocol/lib/Object_h.template b/third_party/inspector_protocol/lib/Object_h.template

index 4ccd88bdab0a73fc6ab5bd59f3761881d3766b40..f6ffc57659e148bb7bf19e12bf86ab21c2f9cb97 100644

--- a/third_party/inspector_protocol/lib/Object_h.template

+++ b/third_party/inspector_protocol/lib/Object_h.template

@@ -15,10 +15,10 @@ namespace {{namespace}} {

class {{config.lib.export_macro}} Object {

public:

- static std::unique_ptr<Object> parse(protocol::Value*, ErrorSupport*);

+ static std::unique_ptr<Object> fromValue(protocol::Value*, ErrorSupport*);

~Object();

- std::unique_ptr<protocol::DictionaryValue> serialize() const;

+ std::unique_ptr<protocol::DictionaryValue> toValue() const;

std::unique_ptr<Object> clone() const;

private:

explicit Object(std::unique_ptr<protocol::DictionaryValue>);