Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2523583004: Disable WebVR Presentation when in MultiWindow mode. (Closed)

Created:
4 years ago by mthiesse
Modified:
4 years ago
Reviewers:
bajones, bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebVR Presentation when in MultiWindow mode. BUG=667781 Committed: https://crrev.com/f212bb93309c374d4ff6c3c4c8a1a1e160eddece Cr-Commit-Position: refs/heads/master@{#433900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mthiesse
PTAL
4 years ago (2016-11-22 16:26:45 UTC) #2
bshe
On 2016/11/22 16:26:45, mthiesse wrote: > PTAL lgtm
4 years ago (2016-11-22 16:35:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523583004/1
4 years ago (2016-11-22 16:52:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-22 17:26:11 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-22 17:29:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f212bb93309c374d4ff6c3c4c8a1a1e160eddece
Cr-Commit-Position: refs/heads/master@{#433900}

Powered by Google App Engine
This is Rietveld 408576698