third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp - Issue 2523573003: Use logicalBottom when computing baselines in vertical-lr inline-blocks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

Issue 2523573003: Use logicalBottom when computing baselines in vertical-lr inline-blocks (Closed)

Patch Set: Rebaselined layout tests. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

index c82fb1e91220dc534395ae116707bd733da56d94..09711ba51840c6e1d5b6152a8750d8c169e0fd66 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

@@ -769,6 +769,8 @@ void InlineFlowBox::placeBoxesInBlockDirection(

// m_layoutObject.isHorizontalWritingMode(). crbug.com/552954

// ASSERT(curr->isHorizontal() ==

// curr->getLineLayoutItem().style()->isHorizontalWritingMode());

+ // We may flip lines in case of verticalLR mode, so we can

+ // assume verticalRL for now.

LayoutUnit overSideMargin =

curr->isHorizontal() ? box.marginTop() : box.marginRight();

LayoutUnit underSideMargin =

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | no next file » | no next file with comments »