third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 2523573003: Use logicalBottom when computing baselines in vertical-lr inline-blocks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2523573003: Use logicalBottom when computing baselines in vertical-lr inline-blocks (Closed)

Patch Set: Rebaselined layout tests. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index 1fdd61270cf2d2d861006e00cc170d0d3bc30b88..c7600356917b2257ce27d393a07cab5f234159be 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -1637,6 +1637,8 @@ LayoutUnit LayoutBlock::lineHeight(bool firstLine,

int LayoutBlock::beforeMarginInLineDirection(

LineDirectionMode direction) const {

+ // InlineFlowBox::placeBoxesInBlockDirection will flip lines in

+ // case of verticalLR mode, so we can assume verticalRL for now.

return (direction == HorizontalLine ? marginTop() : marginRight()).toInt();

}