Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2523573002: Remove destruction observer from file_path_watcher_win.cc (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
dcheng
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove destruction observer from file_path_watcher_win.cc Now that the FilePathWatcher::~FilePathWatcher() is called on the same sequence as FilePathWatcher::Watch() (see https://codereview.chromium.org/2438913003/), the work done in FilePathWatcherImpl::WillDestroyCurrentMessageLoop() can safely be moved to FilePathWatcherImpl::Cancel(). BUG=650318 Committed: https://crrev.com/1e1feb846042722a8df671de070a32374221e499 Cr-Commit-Position: refs/heads/master@{#434150}

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -32 lines) Patch
M base/files/file_path_watcher_win.cc View 1 5 chunks +4 lines, -32 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
fdoray
PTAL
4 years ago (2016-11-22 13:18:05 UTC) #6
dcheng
lgtm
4 years ago (2016-11-23 02:12:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523573002/20001
4 years ago (2016-11-23 11:29:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 12:30:26 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-23 12:32:44 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e1feb846042722a8df671de070a32374221e499
Cr-Commit-Position: refs/heads/master@{#434150}

Powered by Google App Engine
This is Rietveld 408576698